[Cherry-pick]Fix SegFault bug in shape inference #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Cherry-pick #5990 into `rel-1.16.0` branch The bug is SegFault during shape inference if the schema not be set inference function. The schema has `CheckInputOutputType` for shape inference and `Verify` for raw node proto. And the behavior is not fully aligned. ### Motivation and Context fixes #5989 --------- Signed-off-by: opluss <opluss@qq.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rel-1.16.0 #5995 +/- ##
=============================================
Coverage ? 56.82%
=============================================
Files ? 506
Lines ? 30365
Branches ? 4590
=============================================
Hits ? 17254
Misses ? 12283
Partials ? 828 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-Pick #5990 into
rel-1.16.0branchThe bug is SegFault during shape inference if the schema not be set inference function.
The schema has
CheckInputOutputTypefor shape inference andVerifyfor raw node proto. And the behavior is not fully aligned.Motivation and Context
fixes #5989