Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick] Fix unique_name #5994

Merged
merged 1 commit into from Mar 4, 2024
Merged

[Cherry-pick] Fix unique_name #5994

merged 1 commit into from Mar 4, 2024

Conversation

cjvolzka
Copy link
Contributor

@cjvolzka cjvolzka commented Mar 4, 2024

Description

@daquexian @cjvolzka
[Cherry-pick] Fix unique_name
095bd37 
### Description
* Cherry-pick #5992 into `rel-1.16.0` branch
* #5628 missed some getNextUnique() and causes name conflict.

Signed-off-by: daquexian <daquexian566@gmail.com>
@cjvolzka cjvolzka requested a review from a team as a code owner March 4, 2024 21:04
@cjvolzka cjvolzka enabled auto-merge (squash) March 4, 2024 21:04
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (rel-1.16.0@34e00dd). Click here to learn what that means.

Additional details and impacted files 
@@              Coverage Diff              @@
##             rel-1.16.0    #5994   +/-   ##
=============================================
  Coverage              ?   56.81%           
=============================================
  Files                 ?      506           
  Lines                 ?    30357           
  Branches              ?     4589           
=============================================
  Hits                  ?    17246           
  Misses                ?    12283           
  Partials              ?      828

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjvolzka cjvolzka merged commit e6ff7b9 into rel-1.16.0 Mar 4, 2024
68 checks passed
@cjvolzka cjvolzka deleted the fix_unique_name branch March 4, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjvolzka @justinchuby @daquexian