Do not use LFS64 on non-glibc linux (#5668) #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leso-kn <info@lesosoftware.com>
leso-kn
force-pushed
the
fix-non-glibc-build
branch
from
d05bd6a
to
f44275f
Compare
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
|
For reference: job log of a successful musl build with this PR applied. |
jcwchen
added
build
liqunfu
pushed a commit
that referenced
this pull request
Oct 17, 2023
### Description This PR closes #5668 and fixes building onnx on non-glibc linux systems (e.g. Alpine Linux / musl). ### Motivation and Context The latest version of onnx (1.14.1) currently fails to compile on non-glibc systems (e.g. musl) due to an unsupported call to `stat64()` in checker.cc. See the latest [pipeline log](https://gitlab.alpinelinux.org/leso-kn/aports/-/jobs/1143766#L1155) of [aports!52138](https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/52138) for an example case. Signed-off-by: leso-kn <info@lesosoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #5668 and fixes building onnx on non-glibc linux systems (e.g. Alpine Linux / musl).
Motivation and Context
The latest version of onnx (1.14.1) currently fails to compile on non-glibc systems (e.g. musl) due to an unsupported call to
stat64()in checker.cc. See the latest pipeline log of aports!52138 for an example case.