Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows release build error #5659

Closed
justinchuby opened this issue Oct 10, 2023 · 2 comments · Fixed by #5678
Closed

Windows release build error #5659

justinchuby opened this issue Oct 10, 2023 · 2 comments · Fixed by #5678
Labels
bug build Issues related to ONNX builds and packages

Comments

@justinchuby
Copy link
Contributor

Errors like

onnx.lib(checker.obj) : error LNK2001: unresolved external symbol "public: int __thiscall google::protobuf::RepeatedField<int>::size(void)const " (?size@?$RepeatedField@H@protobuf@google@@QBEHXZ) [D:\a\onnx\onnx\onnx\.setuptools-cmake-build\onnx_cpp2py_export.vcxproj]

https://github.com/onnx/onnx/actions/runs/6450822236/job/17510642914

The latest weekly for Windows was not published due to this.
@justinchuby justinchuby added bug build Issues related to ONNX builds and packages labels Oct 10, 2023
@justinchuby
Copy link
Contributor Author

#5596

@justinchuby
Copy link
Contributor Author

cc @jcwchen

This was referenced Oct 16, 2023
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Oct 20, 2023
@jcwchen
Fix Windows Release CI failure due to unresolved external symbol (#5678)
9bf7833 
### Description
<!-- - Describe your changes. -->
Fix Windows Release CI failure : `onnx.lib(checker.obj) : error LNK2001:
unresolved external symbol "public: int __thiscall
google::protobuf::RepeatedField<int>::size(void)const "
(?size@?$RepeatedField@H@protobuf@google@@QBEHXZ)
[D:\a\onnx\onnx\onnx\.setuptools-cmake-build\onnx_cpp2py_export.vcxproj]`
by setting PATH properly. We should use prepend instead of append.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Try to fix #5659. Currently Windows
Release CI starts to fail after #5596.

---------

Signed-off-by: jcwchen <jacky82226@gmail.com>
jcwchen added a commit to jcwchen/onnx that referenced this issue Oct 20, 2023
@jcwchen
Fix Windows Release CI failure due to unresolved external symbol (onn…
21931d2 
…x#5678)

### Description
<!-- - Describe your changes. -->
Fix Windows Release CI failure : `onnx.lib(checker.obj) : error LNK2001:
unresolved external symbol "public: int __thiscall
google::protobuf::RepeatedField<int>::size(void)const "
(?size@?$RepeatedField@H@protobuf@google@@QBEHXZ)
[D:\a\onnx\onnx\onnx\.setuptools-cmake-build\onnx_cpp2py_export.vcxproj]`
by setting PATH properly. We should use prepend instead of append.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Try to fix onnx#5659. Currently Windows
Release CI starts to fail after onnx#5596.

---------

Signed-off-by: jcwchen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug build Issues related to ONNX builds and packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Windows Release CI failure due to unresolved external symbol jcwchen/onnx
1 participant
@justinchuby