Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve removed proto fields #5643

Merged
merged 3 commits into from Oct 3, 2023

Conversation

justinchuby
Copy link
Contributor

Motivation and Context

Reserving removed fields according to the guide
https://protobuf.dev/programming-guides/proto3/#fieldreserved

Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby requested a review from a team as a code owner October 3, 2023 00:25
justinchuby and others added 2 commits October 2, 2023 17:26
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worthy to document this recommended reservation somewhere in onnx to prevent similar future issue.

@justinchuby
Copy link
Contributor Author

Seems worthy to document this recommended reservation somewhere in onnx to prevent similar future issue.

Where should we put it?

@justinchuby justinchuby added this pull request to the merge queue Oct 3, 2023
Merged via the queue into onnx:main with commit 9c452f9 Oct 3, 2023
33 checks passed
@justinchuby justinchuby deleted the justinchu/reserve-fields branch October 3, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants