Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFT-20 version converter #5613

Merged
merged 8 commits into from Sep 27, 2023
Merged

DFT-20 version converter #5613

merged 8 commits into from Sep 27, 2023

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Sep 21, 2023 •
edited

Implement version converter to complete DFT-20.

Requires #5514

Reference: #5514 (comment)

@justinchuby justinchuby mentioned this pull request Sep 21, 2023
Merged
9 tasks
@justinchuby justinchuby added this to the 1.15 milestone Sep 21, 2023
@justinchuby justinchuby marked this pull request as ready for review September 22, 2023 04:20
@justinchuby justinchuby requested review from a team as code owners September 22, 2023 04:20
@justinchuby

This comment was marked as resolved.

Sign in to view
@justinchuby justinchuby mentioned this pull request Sep 22, 2023
Merged
@justinchuby
Squashed commit of the following:
0839a31 
commit f778bb6
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 22 08:04:00 2023 -0700

    Copilot and fix types

commit 408d8c2
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 22 07:56:54 2023 -0700

    Simplify using chatgpt

commit 922a7b3
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 22 07:41:51 2023 -0700

    Simplify cast

commit c363da3
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 21:18:42 2023 -0700

    Add inf back

commit eb3526a
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 21:15:12 2023 -0700

    Axis attribute

commit 662e46e
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 21:12:23 2023 -0700

    Lint

commit 0969eea
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 21:12:10 2023 -0700

    Compile

commit 38b29c6
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 20:57:29 2023 -0700

    AxisAttributeToInput

commit e5a2c02
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 20:09:35 2023 -0700

    EnsureAndReturnNode

commit 482144b
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 20:00:30 2023 -0700

    Update axis_input_to_attribute.h

commit 74bb39c
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 19:25:07 2023 -0700

    Add version converter

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 7afbfd3
Merge: 145f10d 3abb6b3
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 16:34:26 2023 -0700

    Merge branch 'main' into justinchu/dft

commit 145f10d
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:33:36 2023 -0700

    Fix annotations

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 4a08cdd
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 23:22:55 2023 +0000

    CI:apply auto updated documentation/backend test data

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit cd755fe
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:12:32 2023 -0700

    Wording and formatting

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 482ae2c
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:07:53 2023 -0700

    Skip dft

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 57f6b14
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:06:14 2023 -0700

    Sort lines

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit b560a07
Merge: 37c2e17 81ec6a5
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:05:13 2023 -0700

    Merge branch 'main' into justinchu/dft

commit 37c2e17
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 16:01:26 2023 -0700

    Xfail version converter

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit cbf69ae
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 15:56:16 2023 -0700

    Fix stft

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit a7168dd
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 22:49:29 2023 +0000

    CI:apply auto updated documentation/backend test data

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 3ac2ebe
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 15:36:56 2023 -0700

    Fix test graphs

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit bb6b129
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 15:21:34 2023 -0700

    Update onnx/test/shape_inference_test.py

    Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

commit 680059f
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 13:50:00 2023 -0700

    Change default axis to -2

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit e92256b
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 19:50:17 2023 +0000

    Revert init

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit f5bbf06
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 19:48:26 2023 +0000

    Fix node

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit d2a9069
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 10:56:21 2023 -0700

    Update onnx/backend/test/case/node/__init__.py

    Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

commit a017b3b
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 17:15:48 2023 +0000

    Reference

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 5a84146
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 17:07:48 2023 +0000

    Update tests

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 73bdff9
Merge: 5808dd6 a9e0a69
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Thu Sep 21 10:08:38 2023 -0700

    Merge branch 'main' into justinchu/dft

commit 5808dd6
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 21 17:05:39 2023 +0000

    Remove version converter

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit b2a07da
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 19 16:44:08 2023 -0700

    Snapshot

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 4d63e63
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Tue Sep 19 23:43:42 2023 +0000

    CI:apply auto updated documentation

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit b65b01b
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 19 16:22:27 2023 -0700

    Fix test

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit f35f162
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 19 16:22:05 2023 -0700

    Rotate axis order

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 373c478
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 19 15:49:06 2023 -0700

    shapshot

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 021de17
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Sep 18 17:09:58 2023 -0700

    shapshot

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 3300a64
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Mon Sep 18 20:16:13 2023 +0000

    CI:apply auto updated documentation

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 08e001c
Merge: c1d8a90 b302ccc
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Mon Sep 18 13:04:55 2023 -0700

    Merge branch 'main' into justinchu/dft

commit c1d8a90
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Sep 18 13:04:20 2023 -0700

    Add m

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 9e45c39
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Fri Sep 15 20:33:03 2023 +0000

    CI:apply auto updated documentation

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit f51a049
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 15 13:23:35 2023 -0700

    Tweak spec

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit d72510e
Author: justinchuby <justinchuby@users.noreply.github.com>
Date:   Fri Sep 15 19:55:22 2023 +0000

    CI:apply auto updated documentation

    Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 9750a39
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 15 12:44:15 2023 -0700

    Fix import

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 8ea513a
Author: Justin Chu <justinchu@microsoft.com>
Date:   Fri Sep 15 12:12:45 2023 -0700

    Fix build errors

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 21a952e
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 22:08:13 2023 -0700

    Test

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 1bb9254
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 22:01:39 2023 -0700

    Try this

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 3402dfc
Merge: fcce97f 821d156
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Thu Sep 14 17:18:29 2023 -0700

    Merge branch 'main' into justinchu/dft

commit fcce97f
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 17:17:16 2023 -0700

    Version converter

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 4069198
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 17:11:37 2023 -0700

    Improve DFT doc

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 6396c13
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 14:32:47 2023 -0700

    Explain m

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 0cb9f3e
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 14:11:20 2023 -0700

    Fix ONNX_NAMESPACE

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 3aa266c
Merge: 0b99055 b82bd2d
Author: Justin Chu <justinchu@microsoft.com>
Date:   Thu Sep 14 14:08:56 2023 -0700

    Merge branch 'main' into justinchu/dft

commit 0b99055
Merge: 94051ba 02a41bf
Author: Justin Chu <justinchuby@users.noreply.github.com>
Date:   Wed Sep 13 11:57:00 2023 -0700

    Merge branch 'main' into justinchu/dft

commit 94051ba
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 18:40:13 2023 +0000

    format

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 5eea907
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 18:22:45 2023 +0000

    Size check

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 5d702f8
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 18:20:08 2023 +0000

    spec

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 88fb79f
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 18:17:47 2023 +0000

    Implement version converter

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit f809264
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 18:00:59 2023 +0000

    register

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 6f37327
Author: Justin Chu <justinchu@microsoft.com>
Date:   Wed Sep 13 17:59:34 2023 +0000

    Fix function call

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 43d4316
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 12 23:23:34 2023 +0000

    Update defs

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit fcbd610
Merge: b9895a0 fdefbe8
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Sep 12 23:15:23 2023 +0000

    Merge branch 'main' into justinchu/dft

commit b9895a0
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Aug 22 18:46:45 2023 +0000

    namespace

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit dba3f96
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Aug 22 17:39:30 2023 +0000

    Static functions?

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 69d0f4e
Author: Justin Chu <justinchu@microsoft.com>
Date:   Tue Aug 22 17:02:32 2023 +0000

    Refactor ref implementation

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit b712886
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Aug 21 23:43:05 2023 +0000

    utils

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit 632e9e1
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Aug 21 23:14:15 2023 +0000

    Reference

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit b1ac96a
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Aug 21 22:23:29 2023 +0000

    typo

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

commit a9db6ad
Author: Justin Chu <justinchu@microsoft.com>
Date:   Mon Aug 21 18:58:08 2023 +0000

    Create DFT-20

    Signed-off-by: Justin Chu <justinchu@microsoft.com>

Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby and others added 3 commits September 22, 2023 20:25
@justinchuby
Lint
537cc23 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@gramalingam
Handle unknown axis value
49146b2 
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam
Merge remote-tracking branch 'upstream/main' into justin-dft
955b91d
@gramalingam
Add test case
57eefb5 
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam
Add more version downgrade test
bab669c 
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam
Bug fix and cleanup tests
92912fc 
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
jcwchen
jcwchen approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gramalingam for the updates! Basically the code LGTM. Please fix the rest of the lint issues.

I think these 2 added adapters (AxisAttributeToInput and AxisInputToAttribute>) will be very beneficial, because promoting axis from attribute to input is a common scenario. Perhaps we can try to utilize it to cover some existing adapters. Still, that would be a future item and we should forward this PR first.

@jcwchen jcwchen added the version converter Issues related to ONNX version converter label Sep 27, 2023
@gramalingam
Run lint
5dfc451 
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam added this pull request to the merge queue Sep 27, 2023
Merged via the queue into onnx:main with commit e11dacf Sep 27, 2023
35 checks passed
@jcwchen jcwchen mentioned this pull request Sep 27, 2023
Merged
@justinchuby justinchuby deleted the justinchu/dft-2 branch September 27, 2023 15:27
@justinchuby
Copy link
Contributor Author

Thank you @gramalingam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam left review comments

@xadupre xadupre xadupre left review comments

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
version converter Issues related to ONNX version converter
Projects
PR Tracker
Status: Done
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinchuby @gramalingam @jcwchen @xadupre