Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking] Remove deprecated pybind fields in objects #5074

Closed
justinchuby opened this issue Mar 31, 2023 · 1 comment · Fixed by #5921
Closed

[Tracking] Remove deprecated pybind fields in objects #5074

justinchuby opened this issue Mar 31, 2023 · 1 comment · Fixed by #5921
Assignees
@justinchuby
Labels
tracking Tracking issues
Milestone
1.16

Comments

@justinchuby
Copy link
Contributor

Remove deprecated properties in FormalParameter
@jcwchen jcwchen added the tracking Tracking issues label Mar 31, 2023
@jcwchen
Copy link
Member

jcwchen commented Mar 31, 2023

More specific: Remove camelCase properties in FormalParameter. For instance, remove isHomogeneous and only keep is_homogeneous, which is introduced by this PR: #5020.

@justinchuby justinchuby mentioned this issue Mar 31, 2023
Merged
3 tasks
@hamptonm1 hamptonm1 mentioned this issue Jun 1, 2023
Closed
@justinchuby justinchuby added this to the 1.16 milestone Feb 8, 2024
@justinchuby justinchuby mentioned this issue Feb 8, 2024
Merged
@justinchuby justinchuby self-assigned this Feb 8, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
@justinchuby
Remove deprecated properties from FormalParameter (#5921)
b833ee7 
### Description

Remove deprecated properties from FormalParameter.

### Motivation and Context

The properties are set to be removed for the 1.16 release. Fixes
#5074

Signed-off-by: Justin Chu <justinchu@microsoft.com>
andife pushed a commit to andife/onnx that referenced this issue Feb 9, 2024
@justinchuby @andife
Remove deprecated properties from FormalParameter (onnx#5921)
99b7a72 
### Description

Remove deprecated properties from FormalParameter.

### Motivation and Context

The properties are set to be removed for the 1.16 release. Fixes
onnx#5074

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinchuby justinchuby

Labels
tracking Tracking issues
Projects
ONNX triaged work items
Status: Done
Milestone
1.16
Development

Successfully merging a pull request may close this issue.

Remove deprecated properties from FormalParameter justinchuby/onnx
2 participants
@justinchuby @jcwchen