Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass target file path to ufmt config factory #197

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Feb 28, 2024

Stack from ghstack (oldest at bottom):

This fixes ufmt_file to pass the full file path to the ufmt config
factory, rather than just the path's parent. This enables alternate
config factories to make decisions based on the target filename, suffix,
etc that can't be made just based on the parent path. This also aligns
with config factory usage for black and usort.

Fixes #196

This fixes `ufmt_file` to pass the full file path to the ufmt config
factory, rather than just the path's parent. This enables alternate
config factories to make decisions based on the target filename, suffix,
etc that can't be made just based on the parent path. This also aligns
with config factory usage for black and usort.

Fixes #196

[ghstack-poisoned]
amyreese added a commit that referenced this pull request Feb 28, 2024

Verified

This commit was signed with the committer’s verified signature.
JohnRoesler John Roesler
This fixes `ufmt_file` to pass the full file path to the ufmt config
factory, rather than just the path's parent. This enables alternate
config factories to make decisions based on the target filename, suffix,
etc that can't be made just based on the parent path. This also aligns
with config factory usage for black and usort.

Fixes #196

ghstack-source-id: ddaee6f076eb705fa35bef5aa82c699738c3eff4
Pull Request resolved: #197
@amyreese amyreese merged commit ba3275f into gh/amyreese/1/base Feb 28, 2024
16 checks passed
amyreese added a commit that referenced this pull request Feb 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This fixes `ufmt_file` to pass the full file path to the ufmt config
factory, rather than just the path's parent. This enables alternate
config factories to make decisions based on the target filename, suffix,
etc that can't be made just based on the parent path. This also aligns
with config factory usage for black and usort.

Fixes #196

ghstack-source-id: ddaee6f076eb705fa35bef5aa82c699738c3eff4
Pull Request resolved: #197
@amyreese amyreese deleted the gh/amyreese/1/head branch February 28, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant