Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Back to sign in" link if feature hideSignOutLinkInMFA or mfaOnlyFlow is set #3610

Merged

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Apr 23, 2024

Description:

Change for Gen2: if features.hideSignOutLinkInMFA or features.mfaOnlyFlow is true, don't show "Back to sign in" link on terminal page

Note: this fix is already included in Gen3:

export const shouldShowCancelLink = (features?: OktaWidgetFeatures): boolean => {
const { hideSignOutLinkInMFA, mfaOnlyFlow } = features || {};
return !(hideSignOutLinkInMFA || mfaOnlyFlow);

const isCancelAvailable = shouldShowCancelLink(features);

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

(with hideSignOutLinkInMFA or mfaOnlyFlow feature set to true)

Before:

Screenshot 2024-04-23 at 16 16 11

After:

Screenshot 2024-04-23 at 16 16 22

Downstream Monolith Build:

https://bacon-go.aue1e.saasure.net/commits?artifact=monolith&branch=d16t-okta-signin-widget-6fa07cb-6628d774&page=1&pageSize=6&sha=f21d73ddeacabdaf71a11262edccb3991f02af72&tab=main

Copy link
Contributor

@glenfannin-okta glenfannin-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 2d81c92 into master Apr 26, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the od-hide-signout-link-for-terminal-OKTA-718969 branch April 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants