Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export mocks #3607

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

shuowu-okta
Copy link
Contributor

Description:

Only exports mocks from package.json, no lib code change

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

Downstream Monolith Build:

Copy link
Contributor

@lesterchoi-okta lesterchoi-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on exposing the mocks themselves, i.e., JSON files?

@shuowu-okta
Copy link
Contributor Author

shuowu-okta commented Apr 18, 2024

Thoughts on exposing the mocks themselves, i.e., JSON files?

It's actually easier this way to integrate as a dev server (webpack, vite) middleware, instead of writing another one. mocks (json) are still accessible from @okta/okta-signin-widget/mocks/${path-to-file}

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 59284e9 into master Apr 18, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the sw-export-mock-server-OKTA-719095 branch April 18, 2024 20:08
trevoring-okta pushed a commit that referenced this pull request Apr 23, 2024
OKTA-719095 chore: export mocks
remove out workspace dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants