Run playground Gen1/2 in IE11 #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
trevoring-okta
previously approved these changes
Apr 10, 2024
denysoblohin-okta
force-pushed
the
od-ie11-playground-gen2
branch
from
4867cc9
to
ff48771
Compare
| '@babel/preset-typescript' // must run before preset-env: https://github.com/babel/babel/issues/12066 | ||
| ] | ||
| } | ||
| }, | ||
| ] | ||
| }, | ||
| devServer: { | ||
| ...hotReloadOptions, | ||
| host: HOST, |
There was a problem hiding this comment.
Could you also set the host option of the webpack-dev-server to 0.0.0.0 in IE11_COMPAT_MODE since it's common to want to test in a local VM?
There was a problem hiding this comment.
Added
"start:ie11": "IE11_COMPAT_MODE=true OKTA_SIW_HOST=0.0.0.0 ENTRY=default yarn start --watch",
lesterchoi-okta
approved these changes
Apr 12, 2024
trevoring-okta
pushed a commit
that referenced
this pull request
Apr 23, 2024
OKTA-714198 Adds script `start:ie11`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modified webpack configs to use env var
IE11_COMPAT_MODEfor running playground Gen2 in IE11Usage:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: