Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update desc when pass --diff option #1230

Merged
merged 2 commits into from Oct 15, 2023
Merged

refactor: update desc when pass --diff option #1230

merged 2 commits into from Oct 15, 2023

Conversation

wyntau
Copy link
Contributor

@wyntau wyntau commented Nov 8, 2022

show diffed files when pass --diff options, otherwise show staged files

iiroj
iiroj requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@iiroj iiroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can we use changed instead of diffed though?

@wyntau
Copy link
Contributor Author

wyntau commented Nov 9, 2022 •
edited

Thanks for the PR! Can we use changed instead of diffed though?

Sure, I will update the PR.

@iiroj PR updated

@wyntau
Copy link
Contributor Author

wyntau commented Nov 11, 2022

I don't know why these CI fails. Could you please review again? @iiroj

@wyntau wyntau requested a review from iiroj November 11, 2022 12:49
@iiroj
Copy link
Member

iiroj commented Nov 22, 2022

The MR test failure will be fixed in #1200

@wyntau
refactor: update desc when pass --diff option
1f8e52a 
show `diffed files` when pass --diff options, otherwise show `staged files`
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023 •
edited

🦋 Changeset detected

Latest commit: 6a5f84b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iiroj iiroj merged commit 500f45f into lint-staged:master Oct 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iiroj iiroj iiroj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wyntau @iiroj