feat: v20 #305
Merged
feat: v20 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop support for NodeJS v14, v16
wolfy1339
added
Type: Feature
ghost
added this to Features
in 
1 task
63 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
styfle
reviewed
Jul 10, 2023
Leftovers from transition from mocha to jest
wolfy1339
commented
Jul 10, 2023
Comment on lines
+27
to
+36
| // To-Do: Figure out why the objects are not strictly equal | ||
| expect(JSON.stringify(error.response.data.errors)).toStrictEqual( | ||
| JSON.stringify([ | ||
| { | ||
| resource: "Label", | ||
| code: "invalid", | ||
| field: "color", | ||
| }, | ||
| ]), | ||
| ); |
There was a problem hiding this comment.
This is the same situation as in octokit/core.js#563
This will need to be handled in a follow-up issue
There was a problem hiding this comment.
FAIL test/scenarios/errors.test.ts
● api.github.com › (#684) errors-test
expect(received).toStrictEqual(expected) // deep equality
Expected: [{"code": "invalid", "field": "color", "resource": "Label"}]
Received: serializes to the same string
25 | `Validation Failed: {"resource":"Label","code":"invalid","field":"color"}`,
26 | );
> 27 | expect(error.response.data.errors).toStrictEqual([
| ^
28 | {
29 | resource: "Label",
30 | code: "invalid",
at test/scenarios/errors.test.ts:27:44
There was a problem hiding this comment.
Addressed in octokit/core.js#588
nickfloyd
approved these changes
Jul 11, 2023
|
🎉 This PR is included in version 20.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for NodeJS v14, v16