Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate getBufferResponse #710

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 11, 2024

well, why did we extract that function? better reintegrate it :)

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

This stems from the early versions of this library. There used to be different functions for the browser and Node.

There doesn't seem to be a particular reason to have it separate now

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 11, 2024
@wolfy1339 wolfy1339 merged commit 9205e49 into octokit:main Jul 11, 2024
8 checks passed
@Uzlopak Uzlopak deleted the integrate-get-buffer-response branch July 11, 2024 19:18
Copy link

🎉 This issue has been resolved in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants