docs(readme): examples use ESM #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to Inbox
in 
oscard0m
force-pushed
the
docs-suggest-esm-as-default-option
branch
from
6fbf2b0
to
4bfe728
Compare
|
I'm not sure if we should do this? Did we already update the examples in other places? Sorry if I missed a discussion about it |
As far as I know, we have not changed examples in other places and no discussion yet. I assumed this could be changed because of this #586 but I'm creating the proper discussion to talk about this: octokit/octokit.js#2491 |
auto-merge was automatically disabled
July 9, 2023 21:36
Pull request was converted to draft
wolfy1339
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue for this doc adjustment
Behavior
Before the change?
code examples in
README.mduse CommonJSAfter the change?
code examples in
README.mduse ESMAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Type: Documentation