fix(build): add script to fix package.json from build step
#584
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeavenlyEntity
added a commit
to HeavenlyEntity/plugin-throttling.js
that referenced
this pull request
Apr 21, 2023
Organized types, optimized their application and removed old types file as if project continues to scale. Types would be better identified in a folder basis. octokit#584 octokit#583 octokit#106 - Related by setting up tests for proper editing. As before users could not test properly due to project configuration. Will come back to this one once the FATAL error above is confirmed fixed after new release.
|
@oscard0m Would you mind reviewing this PR? |
oscard0m
approved these changes
Apr 21, 2023
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
HeavenlyEntity
added a commit
to HeavenlyEntity/plugin-throttling.js
that referenced
this pull request
Apr 22, 2023
Thought this was the occurrence of `Failed to resolve entry for package "@octokit/plugin-throttling".` Think octokit#584 perhaps fixed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #583
Behavior
Before the change?
The released npm package is missing most of the files generated by the build step.
dist-node,dist-types,dist-web... even though they are generated correctly.After the change?
With the corrected file patterns, npm will publish all the necessary files again.
Other information
This is a mix of an issue with
npm@v9(npm/cli#6164) and the fact we rely onpikafor the build step. Pika has been archived since April 2022 so there is nothing we can do with Pika.Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance