Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retry-count): don't leak retryCount between requests: updated #539

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

mutantcornholio
Copy link
Contributor

@mutantcornholio mutantcornholio commented Oct 29, 2022

This is an updated version of #462.
As asked, replaced express in tests with native http module, and fixed the conflicts.

Closes #462
Fixes #442

CvX and others added 2 commits October 29, 2022 17:53

Verified

This commit was signed with the committer’s verified signature.
mutantcornholio Yuri Volkov

Verified

This commit was signed with the committer’s verified signature.
mutantcornholio Yuri Volkov
wolfy1339
wolfy1339 previously approved these changes Oct 29, 2022

Verified

This commit was signed with the committer’s verified signature.
mutantcornholio Yuri Volkov
@wolfy1339 wolfy1339 linked an issue Oct 30, 2022 that may be closed by this pull request
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you both!

@gr2m gr2m merged commit 4d53e03 into octokit:master Oct 31, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retryCount randomly has a wrong value
4 participants