Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark import of @octokit/request-error as type #437

Merged
merged 1 commit into from Jun 5, 2023
Merged

Conversation

wolfy1339
Copy link
Member

Can possibly help with #436


Behavior

Before the change?

  • The import was getting outputted in the dist JS files

After the change?

  • The import is no longer outputted in the dist JS files

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No
    If Yes, what's the impact:
  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug

@ghost ghost added this to Inbox in JS Jun 5, 2023
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jun 5, 2023
@ghost ghost moved this from Inbox to Bugs in JS Jun 5, 2023
@gr2m gr2m merged commit 711e7a6 into main Jun 5, 2023
8 checks passed
@gr2m gr2m deleted the wolfy1339-patch-1 branch June 5, 2023 22:01
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
JS
  
Bugs
Development

Successfully merging this pull request may close these issues.

None yet

2 participants