Create Check missing required properties in scripts/generated/endpoints.json

[oscard0m]

What happened?
Expected required properties in documentation for create check run are missing:

• name
• head_sha

Instead a strange * property appears (scripts/update-endpoints/generated/endpoints.json Line 9888):

Click to expand!

  "parameters": [
    {
      "name": "owner",
      "description": "",
      "in": "PATH",
      "type": "string",
      "required": true,
      "enum": null,
      "allowNull": false,
      "mapToData": null,
      "validation": null,
      "alias": null,
      "deprecated": null
    },
    {
      "name": "repo",
      "description": "",
      "in": "PATH",
      "type": "string",
      "required": true,
      "enum": null,
      "allowNull": false,
      "mapToData": null,
      "validation": null,
      "alias": null,
      "deprecated": null
    },
    {
      "name": "status",
      "description": "",
      "in": "BODY",
      "type": null,
      "required": false,
      "enum": ["queued", "in_progress"],
      "allowNull": false,
      "mapToData": null,
      "validation": null,
      "alias": null,
      "deprecated": null
    },
    {
      "name": "*",
      "description": "",
      "in": "BODY",
      "type": "object",
      "required": false,
      "enum": null,
      "allowNull": false,
      "mapToData": null,
      "validation": null,
      "alias": null,
      "deprecated": null
    }
  ]

What did you expect to happen?
To get missing name and head_sha required properties when running npm run update-endpoints:fetch-json

What the problem might be
github-openapi-graphql-query lib is returning wrong info probably. Opened issue in that project: gr2m/github-openapi-graphql-query#11

[gr2m]

I tried to reproduce the problems with @octokit/types, but no luck:
playground

However when using the REST API endpoint method .checks.create() no parameters seem to be required at all, or suggested by the TS IntelliSense

playground

The problem seems indeed to be with @octokit/plugin-rest-endpoint-methods playground

I guess you got that far yourself :) I'll have a look why that is and if it's related to the problem you reported at gr2m/github-openapi-graphql-query#11

[gr2m]

It looks like a problem with Omit and Endpoints["POST /repos/{owner}/{repo}/check-runs"]["parameters"]:
playground

Any idea what it could be? I have to move on for today but will try to look more into it on Wednesday

[oscard0m]

It looks like a problem with Omit and Endpoints["POST /repos/{owner}/{repo}/check-runs"]["parameters"]:
playground

Any idea what it could be? I have to move on for today but will try to look more into it on Wednesday

Buf, no idea. I guess we are doing something crazy with this chain of types and an Omit is not able to infer the "omission". I will try to take a look this week too. Thanks for taking the time on checking this and arriving that far :)

[wolfy1339]

Is there any update to this issue, or is it no longer a problem?

[wolfy1339]

As for the parameters missing from the scripts/update-endpoints/generated/endpoints.json file, that doesn't seem to apply any more. They seem to be present now.

For the types issue that should be resolved by #694

[github-actions]

🎉 This issue has been resolved in version 10.1.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀