Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreatedAt nullable #2734

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

lineville
Copy link
Contributor

Resolves #2733 by making the newly added CreatedAt field on the WorkflowJob model nullable.


Behavior

Before the change?

  • Deserializing calls that return a WorkflowJob would fail if running against GHES < 3.9 since the CreatedAt field is not provided on older GHES versions.

After the change?

  • Deserializing calls that return a WorkflowJob succeed running against GHES < 3.9 since the CreatedAt field is nullable and not provided by older GHES versions.

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell merged commit d56404a into octokit:main Jun 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Make WorkflowJob.CreatedAt nullable
2 participants