Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types for Octokit instance broken #81

Closed
wolfy1339 opened this issue Apr 8, 2024 · 2 comments · Fixed by #83
Closed

Types for Octokit instance broken #81

wolfy1339 opened this issue Apr 8, 2024 · 2 comments · Fixed by #83
Labels
released

Comments

@wolfy1339
Copy link
Contributor

Since the switch to ESM in @octokit/core, you can't import from the @octokit/{packageName}/dist-types path anymore.

Since TypeScript can't resolve the import, the type for Octokit is any
@wolfy1339
Copy link
Contributor Author

Should get fixed once octokit/core.js#673 has been landed and this repo upgrades

wolfy1339 added a commit to wolfy1339/octokit that referenced this issue Apr 9, 2024
@wolfy1339
fix: upgrade @octokit/core
748d9f2 
Fixes octoherd#81
@wolfy1339 wolfy1339 mentioned this issue Apr 9, 2024
Merged
@gr2m gr2m closed this as completed in #83 Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: upgrade @octokit/core wolfy1339/octokit
1 participant
@wolfy1339