Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package.json for bundler module resolution #63

Merged
merged 3 commits into from May 30, 2023

Conversation

louisgv
Copy link
Contributor

@louisgv louisgv commented May 28, 2023

When setting moduleResolution: bundler, in TS5, the current exports will not work. Error:

There are types at '/node_modules/formdata-node/@type/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'formdata-node' library may need to update its package.json or typings.ts(7016)

…tion

When setting moduleResolution: bundler, in TS5, the current exports will not work. Error:

There are types at '/node_modules/formdata-node/@type/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'formdata-node' library may need to update its package.json or typings.ts(7016)
@octet-stream
Copy link
Owner

octet-stream commented May 30, 2023

LGTM, but the change is supposed to be made in 5.x branch, because main is for upcoming major release. I will backport and update 5.x version myself, no worries.

@octet-stream octet-stream merged commit 82d2811 into octet-stream:main May 30, 2023
11 checks passed
@octet-stream
Copy link
Owner

octet-stream commented May 30, 2023

Your fix is available in https://github.com/octet-stream/form-data/releases/tag/v5.0.1

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants