Change commands arg name to the singular form
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the plural "commands" suggest that it can take many commands while it only works with one.
|
Thanks for the contribution! Before we can merge this, we need @tomalec to sign the Salesforce Inc. Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plural "commands" suggest that it can take many commands while it only works with one.
After reading the above, I'd expect
mycli help lasers unicornsto show help for both commands, but it only shows forlasers.On one hand, it explains that the argument takes only "Command" (singular).
But having "Commands - Command" makes my head wondering if it was a typo, and if so - where?
After tracking the change, I found it was changed from singular to plural in #454, but I cannot find there any reason why.