feat: no lockfiles in tarballs by default #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
reviewed
Apr 25, 2024
src/commands/pack/tarballs.ts
Outdated
| @@ -9,6 +9,7 @@ Add a pretarball script to your package.json if you need to run any scripts befo | |||
|
|
|||
| static flags = { | |||
| parallel: Flags.boolean({description: 'Build tarballs in parallel.'}), | |||
| 'preserve-lockfiles': Flags.boolean({description: 'Preserve lockfiles in the tarball.'}), | |||
There was a problem hiding this comment.
What's the argument for this being an opt-out flag? As opposed to an opt-in flag like --remove-lockfiles
There was a problem hiding this comment.
default to what most people probably want? That's what we said when we talked.
Could go either way
There was a problem hiding this comment.
I think my preference is to make it an opt-in flag so that we don't risk suddenly breaking other people's builds - even if it's a small risk.
I have a list of of things to do in the next major. If we want, we can switch to an opt-out flag then
| } | ||
| } | ||
|
|
||
| const isLockFile = (f: string) => |
There was a problem hiding this comment.
cool, didn't know about that one, will add.
* fix: compile after install and tests * test: set git config before cli integration tests * test: skip pack tests for pnpm
mdonnalley
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pack:tarballsgets a new--prune-lockfilesflag.This is done after
addDependenciesso that the lockfiles affect that step.forcedotcom/cli#2835