Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Json to JSON, Http to HTTP #5

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Rename Json to JSON, Http to HTTP #5

merged 3 commits into from
Nov 14, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Aug 31, 2023 •
edited

This PR renames functions. Initialisms should have a consistent case.

@jamietanna jamietanna self-requested a review September 11, 2023 20:10
jamietanna
jamietanna requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Unfortunately this right now this is a breaking change (which would be best to avoid if possible) - would you mind keeping the existing definitions, and having them call the new definitions?

@alexandear alexandear requested a review from a team as a code owner November 14, 2023 15:34
jamietanna
jamietanna approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@jamietanna jamietanna merged commit b5265cf into oapi-codegen:main Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @jamietanna