Fix breaking changes recently committed #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request oapi-codegen#19 introduced an extra parameter into a widely used function, which would break existing generated code with the next release. Restore the previous function to its old signature, and add a new one which takes additional options in an options structure.
jamietanna
reviewed
Nov 14, 2023
jamietanna
reviewed
Nov 14, 2023
jamietanna
reviewed
Nov 14, 2023
| // BindStyledParameterWithOptions binds a parameter as described in the Path Parameters | ||
| // section here to a Go object: | ||
| // https://swagger.io/docs/specification/serialization/ | ||
| func BindStyledParameterWithOptions(style string, paramName string, value string, dest any, opts BindStyledParameterOptions) error { |
There was a problem hiding this comment.
Is it worth having style as an option, too?
There was a problem hiding this comment.
Those four args, style, paramName, value, dest are required, which makes them different from the options in the opts struct, where zerovalues are ok.
jamietanna
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #19 introduced an extra parameter into a widely used function, which would break existing generated code with the next release.
Restore the previous function to its old signature, and add a new one which takes additional options in an options structure.