Added required param in BindStyledParameterWithLocation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepmap-marcinr
approved these changes
Nov 13, 2023
|
Thank you. |
This was referenced Nov 14, 2023
Closed
|
Thanks for raising this @itpavelkozlov - to confirm, did you take the code that @renom wrote in #14 or was your implementation from scratch? |
deepmap-marcinr
pushed a commit
to deepmap-marcinr/oapi-codegen-runtime
that referenced
this pull request
Nov 14, 2023
Pull request oapi-codegen#19 introduced an extra parameter into a widely used function, which would break existing generated code with the next release. Restore the previous function to its old signature, and add a new one which takes additional options in an options structure.
jamietanna
pushed a commit
that referenced
this pull request
Nov 14, 2023
Pull request #19 introduced an extra parameter into a widely used function, which would break existing generated code with the next release. Restore the previous function to its old signature, and add a new one which takes additional options in an options structure. Co-authored-by: marcinromaszewicz <marcinromaszewicz@deepmap.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.