Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] fix --no-use example #3479

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

jeremygau
Copy link
Contributor

Fix the --no-use example

When i first try to use the --no-use flag i thought I had to write [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh --no-use" because of the example (see the missed placed double quote)

@ljharb
Copy link
Member

ljharb commented Feb 3, 2025

Thanks! maybe let's reword the comment to provide the entire alternate snippet, so that it's impossible to misinterpret?

@ljharb ljharb marked this pull request as draft February 3, 2025 18:14
@ljharb ljharb force-pushed the fix--no-use-example branch from ad79ae6 to 3c3f66c Compare February 4, 2025 06:13
@ljharb ljharb marked this pull request as ready for review February 4, 2025 06:13
@ljharb ljharb force-pushed the fix--no-use-example branch from 3c3f66c to 247ed8a Compare February 4, 2025 06:13
@ljharb ljharb changed the title [Documentation] README.md: fix --no-use example [readme] fix --no-use example Feb 4, 2025
@ljharb ljharb merged commit 247ed8a into nvm-sh:master Feb 4, 2025
177 of 179 checks passed
ljharb added a commit that referenced this pull request Mar 11, 2025
v0.40.2
New Stuff
 - `install.sh`: add `$ZDOTDIR` to zsh search (#3458)

Fixes
 - `reinstall-packages`: do not reinstall corepack (#3544)
 - avoid bash-specific syntax (#3499)
 - `install-latest-npm`: npm v11 is out
 - `nvm_install_latest_npm`: avoid unbound variable (#3447)
 - give a more helpful message when `lts` alias is mistakenly used (#3441)
 - `nvm ls`, `nvm alias`, `nvm install`: error when an LTS name is invalid
 - `nvm_normalize_lts`: error when an LTS name is not lowercase (#3417)

Documentation
 - [readme] update link
 - [readme] fix `--no-use` example (#3479)
 - [readme] update copyright notice (#3507)
 - [readme] note zsh-nvm's AUTO_USE option (#2670)
 - [readme] add note about reloading zshrc after editing (#3052)
 - [readme] Update shell profile file install notes (#2241)
 - [readme] add docker tips (#2318)
 - [readme] remove `avn` from readme (#3469)
 - [readme] fnm -> nvm.fish (#2541)

Refactors
 - prefer `case` over if/else chains
 - combine `sed -e` invocations/arguments

Tests
 - `nvm exec`/`nvm run`: add `--silent` tests (#1259)
 - [actions] release test needs git tags
 - migrate `installation_iojs` test suite to GitHub Actions (#3476)
 - Migrate slow test suite from Travis CI (#3470)
 - temporarily skip this failing travis test to unblock progress
 - [actions] TOC: use latest LTS node
 - `install.sh`: clean up `nvm_detect_profile` tests
 - `nvm_detect_profile`: refactor (#3467)
 - run urchin tests on pull requests (#3466)
 - update mocks
 - ensure that unit tests use only mocked LTS names
 - [actions] use `node/install` instead of `node/run`

Meta
 - disable blank issues
 - update issue template
 - add DCO (#3456)
 - Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants