Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormField): restore eager-validation prop behavior #3031

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Jan 6, 2025 β€’

πŸ”— Linked issue

Resolves #3006

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@romhml romhml requested a review from benjamincanac January 6, 2025 14:28
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2025 β€’

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 033ed47
Status: βœ…  Deploy successful!
Preview URL: https://2fbf4735.ui-6q2.pages.dev
Branch Preview URL: https://fix-form-eager-validation.ui-6q2.pages.dev

View logs

Copy link

pkg-pr-new bot commented Jan 6, 2025

npm i https://pkg.pr.new/@nuxt/ui@3031

commit: 033ed47

@benjamincanac benjamincanac changed the title fix(FormField)!: restore eager-validation prop fix(FormField)!: restore eager-validation prop Jan 6, 2025
@benjamincanac benjamincanac changed the title fix(FormField)!: restore eager-validation prop fix(FormField): restore eager-validation prop behavior Jan 6, 2025
@benjamincanac benjamincanac merged commit 1f02f55 into v3 Jan 6, 2025
3 checks passed
@benjamincanac benjamincanac deleted the fix/form-eager-validation branch January 6, 2025 17:48
benjamincanac added a commit that referenced this pull request Jan 6, 2025
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I get the same form validation behaviour as in v2?
2 participants