Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ButtonGroup/FormGroup): pass default sizes to children #1875

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix(ButtonGroup/FormGroup): pass default sizes to children #1875

merged 3 commits into from
Jun 19, 2024
+17 −6

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Jun 13, 2024 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #1866

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@romhml romhml force-pushed the fix/default-group-size branch from aab2256 to bffb8b3 Compare June 13, 2024 16:38
@romhml romhml requested a review from benjamincanac June 13, 2024 16:40
@romhml romhml force-pushed the fix/default-group-size branch from bffb8b3 to 337ef41 Compare June 13, 2024 16:51
@benjamincanac benjamincanac changed the title fix: default sizes for ButtonGroup and FormGroup fix(ButtonGroup/FormGroup): pass default sizes to children Jun 18, 2024
romhml added 2 commits June 19, 2024 09:25
@romhml
chore: lint
Loading
Loading status checks…
8dab9fe
@romhml
Merge branch 'dev' of github.com:nuxt/ui into fix/default-group-size

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
a0d5c0b
@benjamincanac benjamincanac merged commit 6b6b03d into dev Jun 19, 2024
2 checks passed
@benjamincanac benjamincanac deleted the fix/default-group-size branch June 19, 2024 10:08
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Jul 28, 2024
@romhml @binhth-1206
fix(ButtonGroup/FormGroup): pass default sizes to children (nuxt#1875)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ebb83b9
@EvertonWingert EvertonWingert mentioned this pull request Jul 29, 2024
Closed
@SamandarTemirxodjayev SamandarTemirxodjayev mentioned this pull request Aug 16, 2024
Open
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Aug 21, 2024
@romhml @binhth-1206
fix(ButtonGroup/FormGroup): pass default sizes to children (nuxt#1875)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
41f218a
@SamandarTemirxodjayev SamandarTemirxodjayev mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

size prop from FormGroup not passed down via app.config?
2 participants
@romhml @benjamincanac