fix: loadIcon
always console warn
#272
Merged
+14
β7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #271
β Type of change
π Description
This PR addresses an issue where the console warning
[Icon] loading icon <name> timed out after <timeout>ms
would be shown, even though the icons were loaded successfully. This happened due to incorrect handling of icon loading timeouts.Changes introduced:
_loadIcon
fails to load the icon, a specific warning message[Icon] failed to load icon <name>
will be logged, giving more visibility into failed loads.[Icon] loading icon <name> timed out after <timeout>ms
will now only appear if the icon fails to load within the specified timeout period.finally
: Ensures that the timeout warning is cleared properly whether the icon is loaded successfully or fails.π Additional context
If you only want the bug fix (
c072229e163fcf738c22fe1bfea9178434651419
), you can pick only that specific commit