Skip to content

Commit 4602c16

Browse files
committedNov 20, 2024
fix: no longer need to be async component, close #301
1 parent a608ae3 commit 4602c16

File tree

2 files changed

+10
-30
lines changed

2 files changed

+10
-30
lines changed
 

Diff for: ‎src/runtime/components/index.ts

+9-29
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { getIcon as _getIcon } from '@iconify/vue'
22
import type { PropType } from 'vue'
3-
import { computed, defineComponent, h, Suspense } from 'vue'
3+
import { computed, defineComponent, h } from 'vue'
44
import type { NuxtIconRuntimeOptions, IconifyIconCustomizeCallback } from '../../types'
55
import { NuxtIconCss } from './css'
66
import { NuxtIconSvg } from './svg'
@@ -9,7 +9,6 @@ import { useAppConfig, useNuxtApp } from '#imports'
99

1010
export default defineComponent({
1111
name: 'NuxtIcon',
12-
inheritAttrs: false,
1312
props: {
1413
name: {
1514
type: String,
@@ -29,13 +28,8 @@ export default defineComponent({
2928
type: Function as PropType<IconifyIconCustomizeCallback>,
3029
required: false,
3130
},
32-
suspensible: {
33-
type: Boolean,
34-
required: false,
35-
default: true,
36-
},
3731
},
38-
setup(props, { slots, attrs }) {
32+
setup(props, { slots }) {
3933
const nuxtApp = useNuxtApp()
4034
const runtimeOptions = useAppConfig().icon as NuxtIconRuntimeOptions
4135
const name = useResolvedName(() => props.name)
@@ -54,29 +48,15 @@ export default defineComponent({
5448
const customize = props.customize || runtimeOptions.customize
5549

5650
return () => h(
57-
Suspense,
58-
{ suspensible: props.suspensible },
51+
component.value,
5952
{
60-
default: () => h(
61-
component.value,
62-
{
63-
...runtimeOptions.attrs,
64-
...attrs,
65-
name: name.value,
66-
class: [
67-
runtimeOptions.class,
68-
attrs.class,
69-
],
70-
style: [
71-
style.value,
72-
attrs.style,
73-
],
74-
customize,
75-
},
76-
slots,
77-
),
78-
fallback: () => h('span', { class: 'iconify iconify-loading' }),
53+
...runtimeOptions.attrs,
54+
name: name.value,
55+
class: runtimeOptions.class,
56+
style: style.value,
57+
customize,
7958
},
59+
slots,
8060
)
8161
},
8262
})

Diff for: ‎src/runtime/components/svg.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const NuxtIconSvg = /* @__PURE__ */ defineComponent({
1717
required: false,
1818
},
1919
},
20-
async setup(props, { slots }) {
20+
setup(props, { slots }) {
2121
const nuxt = useNuxtApp()
2222
const options = useAppConfig().icon as NuxtIconRuntimeOptions
2323
const name = useResolvedName(() => props.name)

0 commit comments

Comments
 (0)
Please sign in to comment.