Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nuxt DevTools client injection failed on Chrome v129 #723

Closed
martinszeltins opened this issue Sep 10, 2024 · 24 comments
Closed

fix: Nuxt DevTools client injection failed on Chrome v129 #723

martinszeltins opened this issue Sep 10, 2024 · 24 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@martinszeltins
Copy link

martinszeltins commented Sep 10, 2024

🐛 The bug

The Nuxt Devtools are not working on the latest Chrome Beta version. It works in all other browsers including Chrome stable but not in Chrome Beta (Version 129.0.6668.29 (Official Build) beta (64-bit))

This is with a completely new / fresh installation of Nuxt.

client.mjs:30 Nuxt DevTools client injection failed
iframe.onload @ client.js?v=3232c809:111
20:36:13.672 client.mjs:30 undefined

Related: #488 (comment)

Screenshot:
devtools

🛠️ To reproduce

https://stackblitz.com/edit/nuxt-starter-vguwcu?file=nuxt.config.ts

🌈 Expected behavior

It should work.

ℹ️ Additional context

No response

@martinszeltins martinszeltins added the bug Something isn't working label Sep 10, 2024
@antfu
Copy link
Member

antfu commented Sep 11, 2024

Shouldn't that be considered as a Chrome Beta bug? It's working on Chrome Stable. I am not sure what we can do here

@martinszeltins
Copy link
Author

Shouldn't that be considered as a Chrome Beta bug? It's working on Chrome Stable. I am not sure what we can do here

Can we investigate why the Nuxt DevTools are not opening in Chrome Beta? Maybe the devtools can be patched to also work in Chrome Beta?

@antfu
Copy link
Member

antfu commented Sep 12, 2024

I don't think we will have the bandwidth to test every Beta version. In this case it looks more like a Chrome bug that they should fix instead. Or we would count on the community to help fix if it's really a Nuxt DevTools issue (PR welcome!).

Marking this as closed for now. Thanks.

@antfu antfu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
@jon-lbm
Copy link

jon-lbm commented Sep 16, 2024

I don't think we will have the bandwidth to test every Beta version. In this case it looks more like a Chrome bug that they should fix instead. Or we would count on the community to help fix if it's really a Nuxt DevTools issue (PR welcome!).

Marking this as closed for now. Thanks.

I'm actually seeing the same issue on my end and I'm using Chrome Version 129.0.6668.42 (Official Build) (arm64), not beta.

@joaolisboa
Copy link

Same issue on my end. On Chromium Engine Version 129.0.6668.42

@antfu antfu reopened this Sep 18, 2024
@antfu antfu added the help wanted Extra attention is needed label Sep 18, 2024
@robert-hoffmann
Copy link

robert-hoffmann commented Sep 19, 2024

Except this is not a beta anymore ..remember chrome moves fast

My dev tools are empty now with chrome 129.0.6668.59 (official)


Problem seems to be somewhere with the iframe, maybe it can't get a handle on it, or some async probem...

image

@robert-hoffmann
Copy link

I don't think we will have the bandwidth to test every Beta version. In this case it looks more like a Chrome bug that they should fix instead. Or we would count on the community to help fix if it's really a Nuxt DevTools issue (PR welcome!).

Marking this as closed for now. Thanks.

Chrome beta moves pretty fast, canary i wouldn't worry about, but something that is broken in beta, is probably gonna hit your user base pretty fast in the official version

I'd include chrome beta as an official testbed for all things nuxt
(food for thought)

@antfu
Copy link
Member

antfu commented Sep 19, 2024

Now, I can reproduce it with v129.

It looks like really a Chrome bug, but I haven't figured out the root cause yet. But it seems like Vue Router gets mismatched in Chrome with the wrong fullPath:

Screenshot 2024-09-19 at 12 31 10

Will keep investigating

@antfu antfu changed the title fix: Nuxt DevTools client injection failed on Chrome Beta fix: Nuxt DevTools client injection failed on Chrome v129 Sep 19, 2024
@robert-hoffmann
Copy link

Maybe something here...

https://chromestatus.com/roadmap

@antfu
Copy link
Member

antfu commented Sep 19, 2024

Went down, it was caused by a circular import in our client bundle. Somehow Chrome v129 failed to resolve and hangs (dynamic import(. '/foo.js') never get resolved). I might need to strim the bundle down to a minimal repro so I can report to Chrome

@antfu
Copy link
Member

antfu commented Sep 19, 2024

Here is the repro: https://github.com/antfu/repro-chrome-v129 - Now I am very confident it's a chrome bug. I reported to Chrome already, let's see how they response, if not I wound try to report to Chromium later.

@Moonlight63
Copy link

Moonlight63 commented Sep 20, 2024

Same bug in MS Edge, which makes sense

@antfu
Copy link
Member

antfu commented Sep 20, 2024

Update: it should be fixed in the next version https://x.com/_shu/status/1837009344153669759

In the meantime, I will check our bundle to see if we can workaround it before that

@antfu antfu closed this as completed in 29b0e39 Sep 20, 2024
@skrabbe001
Copy link

In the meantime, I will check our bundle to see if we can workaround it before that

Which thread should we follow to see if a workaround has been implemented? I see you closed this thread.

@TheAlexLichter
Copy link
Member

The workaround was implemented in 29b0e39

@robert-hoffmann
Copy link

Which thread should we follow to see if a workaround has been implemented? I see you closed this thread.

You'll need to make sure

"@nuxt/devtools": "^1.5.0"

is in your devDependencies, and run pnpm install (maybe with --force), to get it running

@skrabbe001
Copy link

skrabbe001 commented Sep 23, 2024

Nice. I saw manniL wrote the following on Nuxt discord, which may be relevant for other readers of this thread:

when you or a dependency uses an await before imports, that's what causes the Chrome bug

@MickL
Copy link

MickL commented Sep 23, 2024

Had the same error suddenly. Deleted the bun lockfile, which then installed 1.5.0 and it works again!

@thiagonunesbatista
Copy link

thiagonunesbatista commented Sep 29, 2024

Which thread should we follow to see if a workaround has been implemented? I see you closed this thread.

You'll need to make sure

"@nuxt/devtools": "^1.5.0"

is in your devDependencies, and run pnpm install (maybe with --force), to get it running

This solution worked for me too, I am not using the Devtools module anymore. I installed the devtools manually with the npm package and It started working again.

I'm not sure if it's the cause, but the problem started when I installed the nuxt-og-image package.

@MABottiglieri
Copy link

same issue for me with 129.0.6668.90 (official) (a 64 bit)

@blqke
Copy link

blqke commented Oct 7, 2024

same issue for me with 129.0.6668.90 (official) (a 64 bit)

@MABottiglieri Even with @nuxt/devtools to 1.5.2 ?

@hacknug
Copy link

hacknug commented Oct 7, 2024

same issue for me with 129.0.6668.90 (official) (a 64 bit)

@MABottiglieri Even with @nuxt/devtools to 1.5.2 ?

Yeah. Same thing happening to me with Arc and v1.5.2.

Version numbers for Arc and Chromium are:

Versión 1.63.0 (54427)-RC
Chromium Engine Version 129.0.6668.90

EDIT: More context here https://x.com/_shu/status/1837009344153669759

@robert-hoffmann
Copy link

robert-hoffmann commented Oct 8, 2024

Mine works fine here on chrome: 129.0.6668.90, with

devDependencies:
"@nuxt/devtools": "^1.5.2",
"nuxt": "^3.13.2",

Do remember, you need to press: Shift + Alt + D
to open it (by default it remains closed now i think)

@jamols09
Copy link

jamols09 commented Dec 6, 2024

Mine does not even appear when trying to run dev mode.
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests