fix: try update @nuxt/scripts implementation

[Yizack]

🔗 Linked issue

might fix #390

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Tried to update the module to the latest @nuxt/scripts@0.11.1 implementation and nuxt@3.16.0

Since the component needs to expose reset I assign it inside onLoaded, just in case, I tried using proxy directly but the reset wasn't working

[Tkkg1994]

@danielroe
Any idea when we can merge this and get out a new release so we can use the module in nuxt 3.16? Sorry for the hassle...

[danielroe]

I'll review later today.

have you investigated the failing tests?

[Tkkg1994]

@danielroe yes it's an issue with missing types introduced in Yizack@4b5577c

But @Yizack can answer that why he maybe those changes. Were they needed in the src/runtime/components/NuxtTurnstile.vue ?

[Yizack]

@Tkkg1994

@danielroe yes it's an issue with missing types introduced in Yizack@4b5577c

But @Yizack can answer that why he maybe those changes. Were they needed in the src/runtime/components/NuxtTurnstile.vue ?

The missing types issue comes from @nuxt/scripts see nuxt/scripts#419

The changes in NuxtTurnstile.vue were needed due to @nuxt/scripts v0.11.0 breaking changes, a new onLoaded function was introduced. read https://github.com/nuxt/scripts/releases/tag/v0.11.0

[danielroe]

@Yizack I've upgraded nuxt/scripts on its own in #389.

You've done a bit here that updates the implementation as well - I'm not sure whether these changes are still necessary, but if they are, would you add some tests that fail on the current implementation? 🙏

[Yizack]

Added a test to check if turnstile input elements are rendered after click on Load Turnstile button, this test will fail without the changes in NuxtTurnstile.vue because render instance function isn't directly exposed from useScriptCloudflareTurnstile, instance functions are available inside onLoaded in the latest @nuxt/scripts version

Any feedback is welcome ❤️🙏

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 29.34%. Comparing base (dc164cc) to head (01a1dd6).
Report is 163 commits behind head on main.

Files with missing lines	Patch %	Lines
src/runtime/components/NuxtTurnstile.vue	0.00%	20 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #391       +/-   ##
===========================================
+ Coverage   19.26%   29.34%   +10.07%     
===========================================
  Files          12       12               
  Lines         493      351      -142     
  Branches       23       24        +1     
===========================================
+ Hits           95      103        +8     
+ Misses        398      248      -150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[danielroe]

thank you ❤️

[dargmuesli-bot]

🎉 This PR is included in version 0.9.15 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[StirStudios]

On our end this issue is not fully resolved. We are getting:

[@nuxt/scripts 8:49:50 AM] ERROR Nuxt Scripts requires Unhead >= 2, you are using v1.11.20. Please run nuxi upgrade --clean to upgrade...

"@nuxtjs/turnstile": "^0.9.15",
"nuxt": "^3.16.0",

If we run a fresh install without turnstile the install works without any errors. As soon as we add it back we get the error.

Anyone else?

[Yizack]

Hello @StirStudios

That issue doesn't seem to be related to this PR, does your project have other nuxt modules installed? it would be great if you can provide a reproduction link so maintainers can investigate further

[StirStudios]

@Yizack you are totally right, with Nuxt 3.16.0 other changes were made to layers so it was causing an issue here:

extends: [['github:yout_layer', { install: true }]],
So now you do not need to include

{ install: true }

Sorry for any confusion caused!