Skip to content

feat: header, disable setting X-Robots-Tag header #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

HADB
Copy link
Contributor

@HADB HADB commented Aug 14, 2024

πŸ”— Linked issue

resolves #133

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add an option to disable setting X-Robots-Tag header.

Sorry, something went wrong.

@harlan-zw
Copy link
Contributor

Thanks, I think there may be some runtime logic that also applies these headers. Do you think we should be covering that with this flag or should we have two separate flags?

Btw I think we we could disable this feature by default for cloudflare but I'll set up that up outside this PR.

@HADB
Copy link
Contributor Author

HADB commented Aug 14, 2024

Hi, I pushed a new commit which covers runtime header logic.

@harlan-zw
Copy link
Contributor

Great work, thank you for the help. I'll aim to get this merged and released tomorrow.

If you have any time in the meantime to add a test it would be really appreicated.

@HADB
Copy link
Contributor Author

HADB commented Aug 14, 2024 β€’

I added a test for server response header. I have no idea how to test the generated _headers file. But it works as expected when I run generate script manually.

@harlan-zw harlan-zw merged commit 40bc609 into nuxt-modules:main Aug 17, 2024
1 check passed
@harlan-zw harlan-zw changed the title feat: add header config to disable setting X-Robots-Tag header feat: header, disable setting X-Robots-Tag header Aug 17, 2024
HADB added a commit to HADB/hadb.me that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable setting X-Robots-Tag header of routeRules
2 participants