Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add type for unknown appConfig #104

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: add type for unknown appConfig #104

merged 1 commit into from
Oct 25, 2023
+28 −4

Conversation

devTeaa
Copy link
Contributor

@devTeaa devTeaa commented Sep 20, 2023 •
edited
Loading

fix #103

  • The appConfig type from useAppConfig uses a unknown type as value, this PR set the value for the returned appConfig
interface AppConfig {
    [key: string]: unknown;
}
  • Simplify iconName computed logic
Before After
image image

@atinux atinux merged commit 7d9bcf3 into nuxt:main Oct 25, 2023
@renovate renovate bot mentioned this pull request Nov 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error with typescript and build script
2 participants
@devTeaa @atinux