Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept route name argument getRouteBaseName #3446

Merged

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Mar 22, 2025 โ€ข

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #3401

This changes the function getRouteBaseName (returned by useRouteBaseName) to also accept directly passing a route name rather than a full route object. These type for this will narrow if typedPages is enabled, so incorrect usage will cause type checking to fail.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was signed with the committerโ€™s verified signature.
joshka Josh McKinney

Verified

This commit was signed with the committerโ€™s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHubโ€™s verified signature.
@BobbieGoede BobbieGoede self-assigned this Mar 22, 2025
@BobbieGoede BobbieGoede merged commit 3ca5e38 into nuxt-modules:main Mar 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRouteBaseName should accept route.name as string
1 participant