Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform ts locale files with esbuild #3428

Merged

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Mar 20, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Testing with preview release...

Resolves #3406
Resolves #3430

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@BobbieGoede BobbieGoede self-assigned this Mar 20, 2025
Copy link

pkg-pr-new bot commented Mar 20, 2025

npm i https://pkg.pr.new/@nuxtjs/i18n@3428

commit: 34a5e28

@SvenC56
Copy link

SvenC56 commented Mar 21, 2025

npm i https://pkg.pr.new/@nuxtjs/i18n@3428

commit: 7b50972

I get this error while trying to install the module

error @oxc-parser/binding-wasm32-wasi@0.61.0: The CPU architecture "x64" is incompatible with this module.

@BobbieGoede
Copy link
Collaborator Author

@SvenC56
Can you check with npm i https://pkg.pr.new/@nuxtjs/i18n@7b50972? Also, what environment are you installing in (browser/windows/wsl/linux)?

@SvenC56
Copy link

SvenC56 commented Mar 21, 2025

npm i https://pkg.pr.new/@nuxtjs/i18n@7b50972

❯ npm i https://pkg.pr.new/@nuxtjs/i18n@7b50972
npm error code EBADPLATFORM
npm error notsup Unsupported platform for @oxc-parser/binding-wasm32-wasi@0.61.0: wanted {"cpu":"wasm32"} (current: {"cpu":"x64"})
npm error notsup Valid cpu:  wasm32
npm error notsup Actual cpu: x64
npm error A complete log of this run can be found in: /home/ciesloks/.npm/_logs/2025-03-21T09_47_57_605Z-debug-0.log

my system standard ubuntu installation (no wsl):

❯ cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.5 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.5 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

@SvenC56
Copy link

SvenC56 commented Mar 21, 2025

The installation is now working with 8b8173c. Also #3430 is now fixed on my side. 👍🏼

@BobbieGoede
Copy link
Collaborator Author

@SvenC56
Great! Unfortunately this seems to break the functionality in browser environments (like Stackblitz), will need to investigate this some more.

@BobbieGoede BobbieGoede changed the title [DRAFT] fix: transform ts locale files with oxc-transform [DRAFT] fix: transform ts locale files with esbuild Mar 21, 2025
@BobbieGoede
Copy link
Collaborator Author

I'll revert the environment specific changes from this PR, they were necessary for the previous implementation with the experimental transformer oxc-transform, no need for that to delay this fix. 💪

@BobbieGoede BobbieGoede force-pushed the fix/transform-ts-locale-files branch from 8b8173c to 3f1de2b Compare March 21, 2025 10:28
@BobbieGoede BobbieGoede force-pushed the fix/transform-ts-locale-files branch from 3f1de2b to bb86c81 Compare March 21, 2025 10:36
@BobbieGoede BobbieGoede changed the title [DRAFT] fix: transform ts locale files with esbuild fix: transform ts locale files with esbuild Mar 21, 2025
@BobbieGoede BobbieGoede merged commit b9e008c into nuxt-modules:main Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript language files - unexpected token: '{' Typescript locale message files throw build error
2 participants