Skip to content

Commit 5ac89cf

Browse files
author
Pooya Parsa
committedNov 17, 2017
feat(workbox, onegisnal): Use defaultsDeep for options
1 parent d67df15 commit 5ac89cf

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed
 

Diff for: ‎packages/onesignal/index.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ const path = require('path')
22
const { writeFileSync, readFileSync } = require('fs')
33
const hashSum = require('hash-sum')
44
const debug = require('debug')('nuxt:pwa')
5+
const { defaultsDeep } = require('lodash')
56

67
const fixUrl = url => url.replace(/\/\//g, '/').replace(':/', '://')
78
const isUrl = url => url.indexOf('http') === 0 || url.indexOf('//') === 0
@@ -55,7 +56,7 @@ function addOneSignal (moduleOptions) {
5556
}
5657
}
5758

58-
const options = Object.assign(defaults, moduleOptions, this.options.oneSignal)
59+
const options = defaultsDeep({}, this.options.oneSignal, moduleOptions, defaults)
5960

6061
if (options.OneSignalSDK === undefined) {
6162
if (options.cdn) {

Diff for: ‎packages/workbox/index.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const { readFileSync, writeFileSync } = require('fs')
44
const hashSum = require('hash-sum')
55
const escapeStringRegexp = require('escape-string-regexp')
66
const debug = require('debug')('nuxt:pwa')
7+
const { defaultsDeep } = require('lodash')
78

89
const fixUrl = url => url.replace(/\/\//g, '/').replace(':/', '://')
910
const isUrl = url => url.indexOf('http') === 0 || url.indexOf('//') === 0
@@ -43,7 +44,7 @@ function getOptions (moduleOptions) {
4344
}
4445
}
4546

46-
const options = Object.assign({
47+
const defaults = {
4748
autoRegister: true,
4849
routerBase,
4950
publicPath,
@@ -70,7 +71,9 @@ function getOptions (moduleOptions) {
7071
handler: 'networkFirst'
7172
}
7273
]
73-
}, moduleOptions, this.options.workbox)
74+
}
75+
76+
const options = defaultsDeep({}, this.options.workbox, moduleOptions, defaults)
7477

7578
return options
7679
}

0 commit comments

Comments
 (0)
Please sign in to comment.