fix: Can't render pages on older versions of Nuxt if options.watch is missing #52
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on Nuxt v1.4.2 and v2.14.6
arikw
changed the title
arikw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 22 23 +1
Branches 2 3 +1
=========================================
+ Hits 22 23 +1
Continue to review full report at Codecov.
|
arikw
changed the title
arikw
changed the title
arikw
changed the title
|
@arikw thanks |
This was referenced Mar 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
nuxt.config.jsdoesn't contain awatchproperty, Nuxt v1.4.2 fails to render a page with aTypeError: Cannot read property 'push' of undefinederror.This PR adds an empty
watcharray to theoptionsas a fallback to fix the issue.Tested on Nuxt v1.4.2 and v2.14.6