Updatepackages and fix warnings #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkelbu
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
LGTM. Only a couple of comments/questions.
Also have you considered to place
<ItemGroup>
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.CodeStyle">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
in some Directory.Build.props, so we don't have to have the same definition in a lot of places. I've checked if the packages is included in every csproj.
Also the same comment for the NUnit.Analyzers - although it seems like it is used in different folders
manfred-brands
requested changes
Feb 18, 2024
src/NUnitFramework/benchmarks/nunit.framework.benchmarks/nunit.framework.benchmarks.csproj
Outdated
Show resolved
Hide resolved
src/NUnitFramework/nunit.framework.legacy.tests/AssertEqualsTests.cs
Outdated
Show resolved
Hide resolved
This as a result of updating the version of the NUnit.Analyzer
manfred-brands
approved these changes
Feb 19, 2024
src/NUnitFramework/nunit.framework.legacy.tests/nunit.framework.legacy.tests.csproj
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.