Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null string message to be passed to Assert.That #4533

Merged
merged 1 commit into from Oct 31, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #4532

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch @manfred-brands

@manfred-brands
Copy link
Member Author

LGTM. Good catch @manfred-brands

I only noticed it because some my work's NUnit extensions didn't compile anymore with version 4.

@manfred-brands manfred-brands merged commit afeef7c into nunit:master Oct 31, 2023
5 checks passed
@manfred-brands manfred-brands deleted the Issue4532_NullMessage branch October 31, 2023 10:44
@OsirisTerje
Copy link
Member

@manfred-brands Awesome! Very good that you found this before real release. The more we manage to test the beta, the more likely it is we wont have any hotfixes.

@manfred-brands
Copy link
Member Author

@OsirisTerje I'm still at the 'compile' phase. I thought I had the big repository all done, but then the tests failed with missing methods because the NUnitExtensions we have were still trying to resolve NUnit3 signatures of Assert.That. So next step is to update those libraries.

@OsirisTerje
Copy link
Member

@manfred-brands Could be interesting if you wrote up your experiences, could be useful for creating a migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert.That no longer allows 'null' message
3 participants