Tolerance is not supported for IEquatable types #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treatment is now more consistent. It will complain about 'string', 'char', 'enum' and 'IEquatable' For Tuples and user defined types, if one member supports Tolerance, the whole Tuple/Class/Struct does.
manfred-brands
force-pushed
the
Issue4514_Tolerance
branch
from
720adec
to
5027aab
Compare
|
This PR also make treatment of Tolerance more consistent. It will complain about 'string', 'char', 'enum' and 'IEquatable' |
OsirisTerje
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4514
It previously fell back to property comparer if tolerance was used not even calling the type's defined comparison method.