Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore null suppression operator when matching Is.Not.Null #704

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Ignore null suppression operator when matching Is.Not.Null #704

merged 2 commits into from
Mar 16, 2024

Conversation

manfred-brands
Copy link
Member

Fixes #679

mikkelbu
mikkelbu approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice and simple 👍 . I was considering if the replace of ! could remove some instances of the unary negation operator, but I don't think that this can be the case in this context.

@mikkelbu mikkelbu merged commit f771316 into nunit:master Mar 16, 2024
6 checks passed
@mikkelbu mikkelbu added this to the Release 4.1 milestone Mar 16, 2024
@manfred-brands manfred-brands deleted the issues/679_NullSuppressionOperator branch April 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.1
Development

Successfully merging this pull request may close these issues.

Null suppression doesn't work when the body has a null suppression
2 participants
@manfred-brands @mikkelbu