Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect constraint model transformation for named parameters #689

Closed
verdie-g opened this issue Feb 4, 2024 · 0 comments · Fixed by #688
Closed

Incorrect constraint model transformation for named parameters #689

verdie-g opened this issue Feb 4, 2024 · 0 comments · Fixed by #688
Milestone
Release 4.1

Comments

@verdie-g
Copy link
Contributor

verdie-g commented Feb 4, 2024

  • NUnit 3.14.0
  • NUnit.Analyzers 4.0.1

The code fix for NUnit2005 on

Assert.AreEqual(0.1, 0.2, delta: 0.5);

translates it to

Assert.That(0.2, Is.EqualTo(0.1).Within(delta: 0.5));

which does not compile

Error CS1739 : The best overload for 'Within' does not have a parameter named 'delta'
@verdie-g verdie-g mentioned this issue Feb 4, 2024
Merged
@OsirisTerje OsirisTerje transferred this issue from nunit/nunit Feb 5, 2024
@mikkelbu mikkelbu added this to the Release 4.1 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.1
Development

Successfully merging a pull request may close this issue.

Remove name colon on tolerance argument with code fix
2 participants
@mikkelbu @verdie-g