Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .Within makes no sense rule #617

Closed
manfred-brands opened this issue Oct 20, 2023 · 0 comments · Fixed by #612
Closed

Update .Within makes no sense rule #617

manfred-brands opened this issue Oct 20, 2023 · 0 comments · Fixed by #612
Milestone
Release 3.10 / 2.10

Comments

@manfred-brands
Copy link
Member

Because of the newly added PropertyComparer the Within rule is no longer correct. If a class does not implement IEquatable, we now pass each property to the comparer, passing along the tolerance.

The rule needs to stay in place for types implementing IEquatable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.10 / 2.10
Development

Successfully merging a pull request may close this issue.

Add support for NUnit version 4. manfred-brands/nunit.analyzers
2 participants
@mikkelbu @manfred-brands