Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Restore missing asstr import #25323

Merged
merged 1 commit into from Feb 5, 2024

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Dec 6, 2023

The user of this import was removed in the clean-up in #25111, post-2.26.

Used on:

(cmd[4:], asstr(out)))

The user of this import was removed in the cleanup in numpy#25111, post-2.26.
@charris
Copy link
Member

charris commented Dec 6, 2023

Hmm. I plan on backporting f2py from main for the next 1.26 release, so this will probably be fixed when that is done.

@rgommers rgommers added component: numpy.f2py 08 - Backport Used to tag backport PRs labels Dec 8, 2023
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 09 - Backport-Candidate PRs tagged should be backported labels Dec 18, 2023
@charris charris added this to the 1.26.3 release milestone Dec 19, 2023
@charris charris marked this pull request as draft December 25, 2023 22:51
@charris charris marked this pull request as ready for review February 5, 2024 00:57
@charris
Copy link
Member

charris commented Feb 5, 2024

close/reopen

@charris charris closed this Feb 5, 2024
@charris charris reopened this Feb 5, 2024
@charris charris changed the title Restore missing asstr import BUG: Restore missing asstr import Feb 5, 2024
@charris charris merged commit 2fae4d3 into numpy:maintenance/1.26.x Feb 5, 2024
114 of 115 checks passed
@stefanor stefanor deleted the import-asstr branch March 2, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants