Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REL: Prepare for the NumPy 1.24.2 release #23159

Merged
merged 1 commit into from Feb 5, 2023
Merged

REL: Prepare for the NumPy 1.24.2 release #23159

merged 1 commit into from Feb 5, 2023

Conversation

charris
Copy link
Member

@charris charris commented Feb 4, 2023

  • Create 1.24.2-changelog.rst
  • Update 1.24.2-notes.rst

@charris charris added 14 - Release 36 - Build Build related PR labels Feb 4, 2023
@charris charris added this to the 1.24.2 release milestone Feb 4, 2023
@charris
Copy link
Member Author

charris commented Feb 4, 2023 •
edited

Reverting 30535f4 to see if that fixes things.

EDIT: That worked, so the source of the problem is localized to #22972, the backport of #22939.

@charris
Copy link
Member Author

charris commented Feb 4, 2023

The relevant differences to main seem to be in numpy/core/src/npymath/ieee754.cpp and numpy/core/src/npymath/ieee754.c,src, which do not define npy_nextafter in main. This is probably due to the npymath cleanup.

@charris
Copy link
Member Author

charris commented Feb 4, 2023

@mattip Thoughts?

@mattip
Copy link
Member

mattip commented Feb 4, 2023

hmm. Did we never try building wheels after #22972?

@charris
Copy link
Member Author

charris commented Feb 4, 2023

Did we never try building wheels after #22972?

Apparently not :) That's why I make sure to do that in these preparatory PRs. Note that the problem turned up when building wheels for m1.

@charris
Copy link
Member Author

charris commented Feb 5, 2023

Undid the reversion to bring back the original so we can test solutions.

@charris
REL: Prepare for the NumPy 1.24.2 release
1242525 
- Create 1.24.2-changelog.rst
- Update 1.24.2-notes.rst
@charris charris merged commit 85f38ab into numpy:maintenance/1.24.x Feb 5, 2023
@charris charris deleted the prepare-1.24.2-release branch February 5, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
14 - Release 36 - Build Build related PR
Projects
None yet
Milestone
1.24.2 release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charris @mattip