Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of Portuguese in the languages available for feedback #173

Merged
merged 6 commits into from Mar 28, 2024

Conversation

javcasrod
Copy link

No description provided.

@vvatanabe
Copy link
Member

@javcasrod

For Portuguese translations, the correct locale code should be pt rather than pr. Therefore, the ideal filename for the Portuguese translations should be messages_pt.properties. This change ensures that our application correctly identifies and utilizes the Portuguese language resources in accordance with Java's internationalization (i18n) conventions.

Would you be able to update the filename to messages_pt.properties and resubmit the PR? This minor adjustment will ensure that your valuable translations are properly integrated and accessible within our application.

Thank you once again for your contribution and understanding. Please feel free to reach out if you have any questions or need further clarification on this matter. We're looking forward to incorporating your translations into our project.

@javcasrod
Copy link
Author

I have already changed the name of the file, thank you so much for keep in mind the translation we have made.

@vvatanabe
Copy link
Member

@javcasrod Thanks!

@vvatanabe vvatanabe merged commit 86314df into nulab:main Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants