NEOS-1774: Adds dropping and updating triggers to Mysql Init Schema #3382
+491
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 24.22% 24.18% -0.04%
==========================================
Files 414 414
Lines 48340 48366 +26
==========================================
- Hits 11711 11699 -12
- Misses 35508 35550 +42
+ Partials 1121 1117 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchstat Geomean Results0.39% sec/op, -0.03% B/op, 0.97% allocs/op Benchstat results |
nickzelei
approved these changes
Mar 18, 2025
| @@ -114,6 +116,20 @@ func getDatabaseDataForSchemaDiff( | |||
| return nil | |||
| }) | |||
|
|
|||
| trigmu := sync.Mutex{} | |||
| errgrp.Go(func() error { | |||
There was a problem hiding this comment.
is this running in a loop or is anything else other than this goroutine writing to the triggers slice?? if not I think the mutex is not needed.
| return fmt.Errorf("failed to retrieve database table triggers: %w", err) | ||
| } | ||
| for _, tabletrigger := range tabletriggers { | ||
| trigmu.Lock() |
There was a problem hiding this comment.
if the mutex is actually needed, it might be better to just lock it before the for loop and then defer unlock right after. let the for loop hydrate the map and then exit, unlocking the mutex.
| mu.Unlock() | ||
| for _, tableconstraint := range tableconstraints { | ||
| for _, nonFkConstraint := range tableconstraint.NonForeignKeyConstraints { | ||
| mu.Lock() |
There was a problem hiding this comment.
same Q's here. idk if the mutex is needed unless more than one thing in a different goroutine is writing to this map.
If it is needed, it's excessive to lock/unlock within this for loop I think. especially given you are just overwriting the map contents and not checking if there is a collision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.